We’re moving our forums to a new platform.

You can still browse and search existing topics, but you can no longer create new topics or post replies.

For questions, technical issues, or feature requests, please don’t hesitate to contact our support team at support@advancedinstaller.com.

Thank you for your understanding!

psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Patch authoring

Hi

I would like to know what the best method is for multiple patches. Take an example.

1. I have version 1.0 which has script 1.0.sql in it.
2. I have version 1.1 which has script 1.1a.sql and 1.1b in it.
3. I have version 1.2 which has no scripts.

I would like to have a patch which will allow an upgrade from 1.0 to 1.2 and 1.1 to 1.2. Is this the best way i.e. having one patch for both situations.

I know i need to add 1.2 as the new upgraded in the Patch wizard, but what is the best way to add the targets?

1.2 Upgraded
1.1 New Target under 1.2
1.0 New Target under 1.2

or

1.2 Upgraded
1.1 New Target under 1.2
1.0 New Target under 1.1

Thanks
Rudy
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Patch authoring

Hello Rudy,
1.2 Upgraded
1.1 New Target under 1.2
1.0 New Target under 1.2
The first scenario is the correct one.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Thanks for the reply all worked.

Out of interest does the order of the patches added as target matter, i.e. is thee any difference between

1.0
1.1
1.2

and

1.0
1.2
1.1

also what is the purpose of

1.0
1.1
1.2

Thanks
Rudy
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Patch authoring

Hello Rudy,
Out of interest does the order of the patches added as target matter
No it does not matter. When building your patch project Advanced Installer automatically makes the diff between the "Upgraded" and all its "Target" children.
So the UI order from the project is not important, in the end only one MSP will be built that will upgrade any of the "Targets" to the "Upgraded" version.

Best,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Thanks for the reply. It worked OK however i found that i am getting SQL script errors for the following reason.

I have 3 versions 1.0, 1.1, 1.2, 1.3. Each has for example an 'Insert' statement and an 'Alter table' statement. Having done the patch like:

1.3 (upgraded)
---- 1.2 (target)
---- 1.1 (target)
---- 1.0 (target)

I find the following occurs.

- If running patch for 1.0 everything works OK
- If running patch for 1.1 I find that the 1.0 AND the 1.1 scripts run again causing 'duplicate entry' errors from the Insert statement and 'column exists' errors from the Alter statment
- If running patch for 1.2 I find that the 1.0 scripts, the 1.1 scripts AND the 1.2 scripts run again causing 'duplicate entry' errors from the Insert statement and 'column exists' errors from the Alter statment

Is there a way to ensure only the subsequent scripts for the version run. i.e. if patching 1.1 only the 1.2 and 1.3 scripts are run

Thanks
Rudy
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Patch authoring

Hi Rudy,

You can try to set a script condition for each SQL Script to execute only when a particular patch is applied.
We have a predefined condition for this in the edit condition window called "Test if a particular patch is applied".
For more information about this predefined condition please read the Remarks section on this MSDN link.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Thanks for the reply.

Will this still work if i have all the 'patches' (targets) being built in one patch file? If i have 2 SQL scripts 1 in version 0.9.1.0 (0.9.1.0.sql) and 1 in version 0.9.2.0 (0.9.2.0.sql) what would the MEDIASRCPROPNAME be for each scripts

i.e.
for script 0.9.1.0 to run in patch 0.9.1.0 i would use '(PATCH AND PATCH >< MEDIASRCPROPNAME)' where MEDIASRCPROPNAME = ?
for script 0.9.2.0 to run in patch 0.9.2.0 i would use '(PATCH AND PATCH >< MEDIASRCPROPNAME)' where MEDIASRCPROPNAME = ?

Thanks
Rudy
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Patch authoring

Hi Rudy,

To condition each SQL script depending on the version number, try to use the following syntax in your script condition:

Code: Select all

PATCH AND (ProductVersion = "0.9.1")
Where the ProductVersion property contains the version used by the package.
Please note that Windows Installer uses only three version fields for the product version. If a fourth field is specified, it will be ignored.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Hi,

Happy new year.

I tried your suggestion and unfortunately it didnt work for me. I have the following setup:

Currently have versions
0.9.10
0.9.11
0.9.12
0.9.13
1.0.1

The aip attached is for version 1.0.1.

0.9.10, 0.9.11 and 1.0.1 have sql files attached in the aip. The scripts containing '0.9.11' have as their condition "(NOT Installed) OR (PATCH AND (ProductVersion = "0.9.11"))", however, i found that when running a patch from 0.9.13 to 1.0.1 the 0.9.11 scripts are being run. For the scripts containing '1.0.1' i had "(NOT Installed) OR (PATCH AND (ProductVersion = "0.9.11"))" as the script condition but this never ran in the patch from 0.9.13, however, changing it to "(NOT Installed) OR (PATCH )" worked fine (for obvious reasons).

Can you please let me know how i can get it so the scripts will run correctly. i.e. in patch 1.0.1 and if patching from any of the versions (0.9.10 to 0.9.13) that only the script associated with that version is run. So if going from 0.9.10 to 1.0.1 all the scripts will run and if going from 0.9.13 to 1.0.1 only script containing 1.0.1 will run.

Many thanks
Rudy
Attachments
patch.zip
(132.17 KiB) Downloaded 666 times
Patch 1.0.1.0.aip
(2.51 KiB) Downloaded 754 times
iAssist 1.0.1.0.aip
(243.46 KiB) Downloaded 871 times
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Hi,

Have you guys had a chance to look at this yet?

Thanks
Rudy
mihai.petcu
Posts: 3860
Joined: Thu Aug 05, 2010 8:01 am

Re: Patch authoring

Hello Rudy and Happy new year,

I have tested the scenario and it seems the ProductVersion property is assignated only with the upgraded version's value and it doesn't change to any of the intermediate versions during a multiple target patch. Thus, the approach I mentioned in my previous post is not a complete one in your case.

A patch is considered to be a repair/maintenance in Windows Installer so just to clarify things, this condition:

Code: Select all

(NOT Installed)
will always resolve to false during a patch. It would be enough just to check the script execution "during maintenance(repair/modify)" option.

Also this condition(using the OR operator):
(NOT Installed) OR (PATCH AND (ProductVersion = "0.9.11"))
resolves to true if any or both conditions are true. Moreover, even if the (NOT Installed) always resolved to true during a "not installed" patch, it would still be wrong because (PATCH AND (ProductVersion = "0.9.11") could be either true or false, the whole condition would resolve to true in each case. Using AND instead of OR would have accomplished what you wanted. Please note that this is a condition logic correction and the properties are not relevant.

After further investigation and discussions with the team we thought of another solution scenario you can try. Here are the steps to be applied from within your own custom action in the upgraded(1.0.1) project :
  • parse the OLDPRODUCTS property which contains all the product codes of the already installed versions
  • perform a custom registry search using the parsed installed version's product code in this location

    Code: Select all

    HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall
    and retrieve the "DisplayVersion" value
  • get the "DisplayVersion" in a public property inside your project and use the property to condition each script(e.g. if version 0.9.10 is installed then only the 0.9.11 and 1.0.1 scripts need to run). It should look something like :

    Code: Select all

    PATCH AND (ScriptVersion>DISPLAY_VERSION)
Another simpler approach would be to rethink your package strategy and perhaps deliver the 1.0.1 version in one single major upgrade package.

Regards,
Mihai
Mihai Petcu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Hi Mihai,

Thanks for the reply, although it is getting a bit frustrating now, as this patch is over 2 weeks late now.

What you have written makes perfect sense, but i would not know how to implement it. I looked at this post http://www.advancedinstaller.com/forums ... f=2&t=7907 and it still is not apparent as i do not think it returns the displayversion. Therefore, is it possible that you can send a sample aip file or even update my iAssist 1.0.1.0.aip with the solution proposed.

Many thanks
Rudy
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Having looked at the aforementioned post i have the following .aip

The log is as follows

=== Verbose logging started: 05/01/2011 10:31:03 Build type: SHIP UNICODE 5.00.7600.00 Calling process: C:\Installer\iAssist\Latest Build\iAssist Setup 1.0.1.0.exe ===
MSI (c) (C0:14) [10:31:03:253]: SOFTWARE RESTRICTION POLICY: Verifying package --> 'C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi' against software restriction policy
MSI (c) (C0:14) [10:31:03:260]: Note: 1: 2262 2: DigitalSignature 3: -2147287038
MSI (c) (C0:14) [10:31:03:284]: SOFTWARE RESTRICTION POLICY: C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi is not digitally signed
MSI (c) (C0:14) [10:31:03:296]: SOFTWARE RESTRICTION POLICY: C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi is permitted to run at the 'unrestricted' authorization level.
MSI (c) (C0:14) [10:31:03:358]: Cloaking enabled.
MSI (c) (C0:14) [10:31:03:367]: Attempting to enable all disabled privileges before calling Install on Server
MSI (c) (C0:14) [10:31:03:480]: End dialog not enabled
MSI (c) (C0:14) [10:31:03:571]: Original package ==> C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi
MSI (c) (C0:14) [10:31:03:583]: Package we're running from ==> C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi
MSI (c) (C0:14) [10:31:03:594]: Machine policy value 'DisableUserInstalls' is 0
MSI (c) (C0:14) [10:31:03:603]: APPCOMPAT: Compatibility mode property overrides found.
MSI (c) (C0:14) [10:31:03:608]: APPCOMPAT: looking for appcompat database entry with ProductCode '{A00C4AF2-B102-4E5F-B006-119469E1A166}'.
MSI (c) (C0:14) [10:31:03:616]: APPCOMPAT: no matching ProductCode found in database.
MSI (c) (C0:14) [10:31:03:630]: MSCOREE not loaded loading copy from system32
MSI (c) (C0:14) [10:31:03:637]: Machine policy value 'TransformsSecure' is 0
MSI (c) (C0:14) [10:31:03:641]: User policy value 'TransformsAtSource' is 0
MSI (c) (C0:14) [10:31:03:650]: Note: 1: 2205 2: 3: MsiFileHash
MSI (c) (C0:14) [10:31:03:658]: Machine policy value 'DisablePatch' is 0
MSI (c) (C0:14) [10:31:03:666]: Machine policy value 'AllowLockdownPatch' is 0
MSI (c) (C0:14) [10:31:03:675]: Machine policy value 'DisableLUAPatching' is 0
MSI (c) (C0:14) [10:31:03:683]: Machine policy value 'DisableFlyWeightPatching' is 0
MSI (c) (C0:14) [10:31:03:692]: APPCOMPAT: looking for appcompat database entry with ProductCode '{A00C4AF2-B102-4E5F-B006-119469E1A166}'.
MSI (c) (C0:14) [10:31:03:700]: APPCOMPAT: no matching ProductCode found in database.
MSI (c) (C0:14) [10:31:03:708]: Transforms are not secure.
MSI (c) (C0:14) [10:31:03:716]: PROPERTY CHANGE: Adding MsiLogFileLocation property. Its value is 'C:\Users\Rudy\AppData\Local\Temp\logCCEF.tmp'.
MSI (c) (C0:14) [10:31:03:724]: No Command Line.
MSI (c) (C0:14) [10:31:03:733]: PROPERTY CHANGE: Adding PackageCode property. Its value is '{1FDADAF3-1D42-4E63-A385-F0B4DF0F0AEF}'.
MSI (c) (C0:14) [10:31:03:741]: Product Code passed to Engine.Initialize: '(none)'
MSI (c) (C0:14) [10:31:03:749]: Product Code from property table before transforms: '{A00C4AF2-B102-4E5F-B006-119469E1A166}'
MSI (c) (C0:14) [10:31:03:758]: Product Code from property table after transforms: '{A00C4AF2-B102-4E5F-B006-119469E1A166}'
MSI (c) (C0:14) [10:31:03:766]: Product not registered: beginning first-time install
MSI (c) (C0:14) [10:31:03:775]: PROPERTY CHANGE: Adding ProductState property. Its value is '-1'.
MSI (c) (C0:14) [10:31:03:783]: Note: 1: 1402 2: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Policies\Explorer 3: 2
MSI (c) (C0:14) [10:31:03:791]: Entering CMsiConfigurationManager::SetLastUsedSource.
MSI (c) (C0:14) [10:31:03:799]: User policy value 'SearchOrder' is 'nmu'
MSI (c) (C0:14) [10:31:03:808]: Adding new sources is allowed.
MSI (c) (C0:14) [10:31:03:816]: PROPERTY CHANGE: Adding PackagecodeChanging property. Its value is '1'.
MSI (c) (C0:14) [10:31:03:825]: Package name extracted from package path: 'iAssist.msi'
MSI (c) (C0:14) [10:31:03:833]: Package to be registered: 'iAssist.msi'
MSI (c) (C0:14) [10:31:03:841]: Note: 1: 2262 2: AdminProperties 3: -2147287038
MSI (c) (C0:14) [10:31:03:874]: Machine policy value 'DisableMsi' is 0
MSI (c) (C0:14) [10:31:03:882]: Machine policy value 'AlwaysInstallElevated' is 0
MSI (c) (C0:14) [10:31:03:891]: User policy value 'AlwaysInstallElevated' is 0
MSI (c) (C0:14) [10:31:03:899]: Product installation will be elevated because user is admin and product is being installed per-machine.
MSI (c) (C0:14) [10:31:03:907]: Running product '{A00C4AF2-B102-4E5F-B006-119469E1A166}' with elevated privileges: Product is assigned.
MSI (c) (C0:14) [10:31:03:916]: TRANSFORMS property is now:
MSI (c) (C0:14) [10:31:03:924]: PROPERTY CHANGE: Adding VersionDatabase property. Its value is '200'.
MSI (c) (C0:14) [10:31:03:933]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming
MSI (c) (C0:14) [10:31:03:941]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\Favorites
MSI (c) (C0:14) [10:31:03:950]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Network Shortcuts
MSI (c) (C0:14) [10:31:03:958]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\Documents
MSI (c) (C0:14) [10:31:03:966]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Printer Shortcuts
MSI (c) (C0:14) [10:31:03:974]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Recent
MSI (c) (C0:14) [10:31:03:983]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\SendTo
MSI (c) (C0:14) [10:31:03:991]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Templates
MSI (c) (C0:14) [10:31:04:000]: SHELL32::SHGetFolderPath returned: C:\ProgramData
MSI (c) (C0:14) [10:31:04:008]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Local
MSI (c) (C0:14) [10:31:04:016]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\Pictures
MSI (c) (C0:14) [10:31:04:025]: SHELL32::SHGetFolderPath returned: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools
MSI (c) (C0:14) [10:31:04:033]: SHELL32::SHGetFolderPath returned: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Startup
MSI (c) (C0:14) [10:31:04:041]: SHELL32::SHGetFolderPath returned: C:\ProgramData\Microsoft\Windows\Start Menu\Programs
MSI (c) (C0:14) [10:31:04:049]: SHELL32::SHGetFolderPath returned: C:\ProgramData\Microsoft\Windows\Start Menu
MSI (c) (C0:14) [10:31:04:057]: SHELL32::SHGetFolderPath returned: C:\Users\Public\Desktop
MSI (c) (C0:14) [10:31:04:066]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Administrative Tools
MSI (c) (C0:14) [10:31:04:074]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup
MSI (c) (C0:14) [10:31:04:082]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Start Menu\Programs
MSI (c) (C0:14) [10:31:04:091]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Start Menu
MSI (c) (C0:14) [10:31:04:099]: SHELL32::SHGetFolderPath returned: C:\Users\Rudy\Desktop
MSI (c) (C0:14) [10:31:04:108]: SHELL32::SHGetFolderPath returned: C:\ProgramData\Microsoft\Windows\Templates
MSI (c) (C0:14) [10:31:04:116]: SHELL32::SHGetFolderPath returned: C:\Windows\Fonts
MSI (c) (C0:14) [10:31:04:124]: Note: 1: 2898 2: MS Sans Serif 3: MS Sans Serif 4: 0 5: 16
MSI (c) (C0:14) [10:31:04:172]: MSI_LUA: Setting MsiRunningElevated property to 1 because the install is already running elevated.
MSI (c) (C0:14) [10:31:04:188]: PROPERTY CHANGE: Adding MsiRunningElevated property. Its value is '1'.
MSI (c) (C0:14) [10:31:04:215]: PROPERTY CHANGE: Adding Privileged property. Its value is '1'.
MSI (c) (C0:14) [10:31:04:224]: Note: 1: 1402 2: HKEY_CURRENT_USER\Software\Microsoft\MS Setup (ACME)\User Info 3: 2
MSI (c) (C0:14) [10:31:04:248]: PROPERTY CHANGE: Adding USERNAME property. Its value is 'Rudy'.
MSI (c) (C0:14) [10:31:04:257]: Note: 1: 1402 2: HKEY_CURRENT_USER\Software\Microsoft\MS Setup (ACME)\User Info 3: 2
MSI (c) (C0:14) [10:31:04:290]: PROPERTY CHANGE: Adding DATABASE property. Its value is 'C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi'.
MSI (c) (C0:14) [10:31:04:314]: PROPERTY CHANGE: Adding OriginalDatabase property. Its value is 'C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\iAssist.msi'.
MSI (c) (C0:14) [10:31:04:323]: Machine policy value 'MsiDisableEmbeddedUI' is 0
MSI (c) (C0:14) [10:31:04:331]: EEUI - Disabling MsiEmbeddedUI due to existing external or embedded UI
MSI (c) (C0:14) [10:31:04:339]: PROPERTY CHANGE: Adding SourceDir property. Its value is 'C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\'.
MSI (c) (C0:14) [10:31:04:348]: PROPERTY CHANGE: Adding SOURCEDIR property. Its value is 'C:\Users\Rudy\AppData\Roaming\IT PROz\iAssist\install\'.
MSI (c) (C0:A4) [10:31:04:357]: PROPERTY CHANGE: Adding VersionHandler property. Its value is '5.00'.
=== Logging started: 05/01/2011 10:31:04 ===
MSI (c) (C0:14) [10:31:04:373]: Note: 1: 2262 2: PatchPackage 3: -2147287038
MSI (c) (C0:14) [10:31:04:381]: Machine policy value 'DisableRollback' is 0
MSI (c) (C0:14) [10:31:04:389]: User policy value 'DisableRollback' is 0
MSI (c) (C0:14) [10:31:04:398]: PROPERTY CHANGE: Adding UILevel property. Its value is '5'.
MSI (c) (C0:14) [10:31:04:406]: MsiOpenPackageEx is returning 0
MSI (c) (C0:14) [10:31:04:414]: MsiOpenPackage is returning 0
MSI (c) (C0:14) [10:31:04:427]: PROPERTY CHANGE: Adding AIEXTERNALUI property. Its value is '5'.
MSI (c) (C0:14) [10:31:04:431]: PROPERTY CHANGE: Adding AI_SETUPEXEPATH property. Its value is 'C:\Installer\iAssist\Latest Build\iAssist Setup 1.0.1.0.exe'.
MSI (c) (C0:14) [10:31:04:439]: PROPERTY CHANGE: Adding SETUPEXEDIR property. Its value is 'C:\Installer\iAssist\Latest Build\'.
MSI (c) (C0:14) [10:31:04:448]: PROPERTY CHANGE: Adding PRIMARYFOLDER property. Its value is 'APPDIR'.
MSI (c) (C0:14) [10:31:04:456]: PROPERTY CHANGE: Adding CLIENTPROCESSID property. Its value is '4800'.
MSI (c) (C0:14) [10:31:04:466]: Doing action: AI_SET_INSTALL
Action 10:31:04: AI_SET_INSTALL.
Action start 10:31:04: AI_SET_INSTALL.
MSI (c) (C0:14) [10:31:04:590]: PROPERTY CHANGE: Adding AI_INSTALL property. Its value is '1'.
Action ended 10:31:04: AI_SET_INSTALL. Return value 1.
MSI (c) (C0:14) [10:31:04:606]: Doing action: AI_ResolveKnownFolders
Action 10:31:04: AI_ResolveKnownFolders.
Action start 10:31:04: AI_ResolveKnownFolders.
MSI (c) (C0:74) [10:31:04:683]: Invoking remote custom action. DLL: C:\Users\Rudy\AppData\Local\Temp\MSIDEEC.tmp, Entrypoint: AI_ResolveKnownFolders
MSI (c) (C0:FC) [10:31:04:707]: Cloaking enabled.
MSI (c) (C0:FC) [10:31:04:731]: Attempting to enable all disabled privileges before calling Install on Server
MSI (c) (C0:FC) [10:31:04:739]: Connected to service for CA interface.
MSI (c) (C0!14) [10:31:04:835]: PROPERTY CHANGE: Adding WindowsLibrariesFolder property. Its value is 'C:\Users\Rudy\AppData\Roaming\Microsoft\Windows\Libraries'.
MSI (c) (C0!14) [10:31:04:849]: PROPERTY CHANGE: Adding SavedGamesFolder property. Its value is 'C:\Users\Rudy\Saved Games'.
MSI (c) (C0!14) [10:31:04:874]: PROPERTY CHANGE: Adding PublicDocumentsFolder property. Its value is 'C:\Users\Public\Documents'.
Action ended 10:31:04: AI_ResolveKnownFolders. Return value 1.
MSI (c) (C0:14) [10:31:04:931]: Doing action: PrepareDlg
Action 10:31:04: PrepareDlg.
Action start 10:31:05: PrepareDlg.
MSI (c) (C0:A8) [10:31:05:143]: Note: 1: 2205 2: 3: AI_ControlEx
MSI (c) (C0:A8) [10:31:05:191]: Note: 1: 2228 2: 3: AI_ControlEx 4: SELECT `Dialog_`,`Control`,`Type`,`Attributes`,`Data` FROM `AI_ControlEx` WHERE `Dialog_` = 'PrepareDlg'
Action ended 10:31:05: PrepareDlg. Return value 1.
MSI (c) (C0:14) [10:31:05:264]: Doing action: AppSearch
Action 10:31:05: AppSearch. Searching for installed applications
Action start 10:31:05: AppSearch.
AppSearch: Property: DISPLAY_VERSION, Signature: AppSearchSign
MSI (c) (C0:14) [10:31:05:395]: Note: 1: 2262 2: Signature 3: -2147287038
Action ended 10:31:05: AppSearch. Return value 1.
MSI (c) (C0:14) [10:31:05:529]: Doing action: FindRelatedProducts
Action 10:31:05: FindRelatedProducts. Searching for related applications
Action start 10:31:05: FindRelatedProducts.
Action ended 10:31:05: FindRelatedProducts. Return value 1.
MSI (c) (C0:14) [10:31:05:563]: Doing action: OldProductFinder.dll
Action 10:31:05: OldProductFinder.dll.
Action start 10:31:05: OldProductFinder.dll.
MSI (c) (C0:7C) [10:31:05:589]: Invoking remote custom action. DLL: C:\Users\Rudy\AppData\Local\Temp\MSIE276.tmp, Entrypoint: FindOldProductCode
CustomAction OldProductFinder.dll returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)
Action ended 10:31:05: OldProductFinder.dll. Return value 3.
MSI (c) (C0:14) [10:31:05:613]: Doing action: FatalError
Action 10:31:05: FatalError.
Action start 10:31:05: FatalError.
MSI (c) (C0:A8) [10:31:05:642]: Note: 1: 2205 2: 3: AI_ControlEx
MSI (c) (C0:A8) [10:31:05:646]: Note: 1: 2228 2: 3: AI_ControlEx 4: SELECT `Dialog_`,`Control`,`Type`,`Attributes`,`Data` FROM `AI_ControlEx` WHERE `Dialog_` = 'FatalError'
Action ended 10:31:20: FatalError. Return value 1.
MSI (c) (C0:14) [10:31:20:730]: Doing action: AI_CleanPrereq
Action 10:31:20: AI_CleanPrereq.
Action start 10:31:20: AI_CleanPrereq.
MSI (c) (C0:04) [10:31:20:758]: Invoking remote custom action. DLL: C:\Users\Rudy\AppData\Local\Temp\MSI1DB2.tmp, Entrypoint: CleanPrereq
Action ended 10:31:20: AI_CleanPrereq. Return value 1.
MSI (c) (C0:14) [10:31:20:785]: Doing action: FatalError
Action 10:31:20: FatalError.
Action start 10:31:20: FatalError.
Action ended 10:31:20: FatalError. Return value 2.
MSI (c) (C0:30) [10:31:20:819]: Destroying RemoteAPI object.
MSI (c) (C0:FC) [10:31:20:828]: Custom Action Manager thread ending.
=== Verbose logging stopped: 05/01/2011 10:31:20 ===

Any suggestions will be appreciated. It is due to the dll which was added

Thanks
Rudy
Attachments
iAssist 1.0.1.0.aip
(244.54 KiB) Downloaded 1162 times
psaunders
Posts: 30
Joined: Fri Oct 29, 2010 3:08 pm

Re: Patch authoring

Any help from the support team??

Rudy
Bogdan
Posts: 2796
Joined: Tue Jul 07, 2009 7:34 am
Contact: Website

Re: Patch authoring

Hi Rudy,

Sorry for the late reply. I see you have tried to use the custom action from the post you have mentioned to find the product code.

The log contains the following:

Code: Select all

MSI (c) (C0:14) [10:31:05:563]: Doing action: OldProductFinder.dll
Action 10:31:05: OldProductFinder.dll. 
Action start 10:31:05: OldProductFinder.dll.
MSI (c) (C0:7C) [10:31:05:589]: Invoking remote custom action. DLL: C:\Users\Rudy\AppData\Local\Temp\MSIE276.tmp, Entrypoint: FindOldProductCode
CustomAction OldProductFinder.dll returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)
Action ended 10:31:05: OldProductFinder.dll. Return value 3.
MSI (c) (C0:14) [10:31:05:613]: Doing action: FatalError
This means the custom action failed. Probably you've made changes that cause it to fail, you need to debug the custom action and see where it fails.

Also, I noticed in the aip file hat you are still using "NOT Installed" in the execution condition of the scripts. As Mihai explained previously, this part of the condition is not necessary because it will always resolve to FALSE when running a patch. The patch it always applied to a product that is already installed.

Regards,
Bogdan
Bogdan Mitrache - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Common Problems”