We’re moving our forums to a new platform.

You can still browse and search existing topics, but you can no longer create new topics or post replies.

For questions, technical issues, or feature requests, please don’t hesitate to contact our support team at support@advancedinstaller.com.

Thank you for your understanding!

Ruud Poutsma
Posts: 2
Joined: Fri Apr 25, 2014 8:59 am

Diffable project file

First off, let me take this space to say I start to really love Advanced Installer! Good working UI in most cases, and fulfills our needs mostly.

We work with Git repositories to place our code in. In these repostiories we also have .aip and .aiproj files. We strive for high code quality within our team, where every dot, space, tab, and any other character counts. We achieve this through code reviews and commit reviews. We do so with all C#, C++, .bat, xml files. However, it is very difficult to achieve this with .aip files because:
  • Hard to understand what is meant reading the .aip code
  • Many seemingly unnecessary changes after just opening and closing an .aip project
  • One huge file with anything and everything in it
We would really like to be able to perform sane code reviews on changes made in the installer. Above constraints make those hard or impossible to do. (A) (D|d)ifferent format(s) enabled to perform difference checking on (diffable) would solve this issue.
Daniel
Posts: 8283
Joined: Mon Apr 02, 2012 1:11 pm
Contact: Website

Re: Diffable project file

Hello and welcome to Advanced Installer forums,

Thank you for your interest in Advanced Installer and for your positive words.

Our .AIPs (project files) are using the XML format and indentation and this should allow you to easily perform a diff operation between different versions of a project file (using a diff too, e.g. we are using TortoiseSVN for diff operations).

On the other hand there should be no change after just opening and closing an .aip file in Advanced Installer. Can you isolate the behavior in a sample and send it us alongside with a test case scenario so we can investigate this?

All the best,
Daniel
Daniel Radu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube
Ruud Poutsma
Posts: 2
Joined: Fri Apr 25, 2014 8:59 am

Re: Diffable project file

Looking to the xml file contents, I cannot easily make any sense of it. It is unworkable for code reviews, as no comprehension can be reached as to the proposed changes reflect the intended change.

I will try to reproduce the chaning aiproj file behaviour asap.
Daniel
Posts: 8283
Joined: Mon Apr 02, 2012 1:11 pm
Contact: Website

Re: Diffable project file

Hello,
Looking to the xml file contents, I cannot easily make any sense of it. It is unworkable for code reviews, as no comprehension can be reached as to the proposed changes reflect the intended change.
Unfortunately, the XML file format is the current format used by our project files and I think this won't be changing soon. Thank you for your understanding.
I will try to reproduce the chaning aiproj file behaviour asap.
I've searched in our bug tracking system and I can confirm that indeed there was an issue in our previous versions of Advanced Installer (10.7.1 and lower) regarding the changing of the .aiproj (project file created by the AI extension for Visual Studio) during the solution load and close operations. However, starting with 10.8 version of Advanced Installer this issue was fixed. Can you still replicate the issue using our latest version of Advanced Installer (11.1)?

All the best,
Daniel
Daniel Radu - Advanced Installer Team
Follow us: Twitter - Facebook - YouTube

Return to “Feature Requests”